[VEN-2770] Revoke Guardian Permissions #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web3rover
changed the title
chechu
reviewed
Sep 2, 2024
vips/vip-355/bscmainnet.ts
Outdated
Comment on lines
42
to
53
| { | ||
| target: ARBITRUM_ONE_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [arbitrumone.REDSTONE_ORACLE, "setTokenConfig(TokenConfig)", arbitrumone.GUARDIAN], | ||
| dstChainId: LzChainId.arbitrumone, | ||
| }, | ||
| { | ||
| target: ARBITRUM_ONE_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [arbitrumone.REDSTONE_ORACLE, "setDirectPrice(address,uint256)", arbitrumone.GUARDIAN], | ||
| dstChainId: LzChainId.arbitrumone, | ||
| }, |
There was a problem hiding this comment.
I wouldn't revoke these permissions. They are granted in the ChainlinkOracle, that is similar to this oracle
Comment on lines
+175
to
+186
| { | ||
| target: ETHEREUM_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [ethereum.REDSTONE_ORACLE, "setTokenConfig(TokenConfig)", ethereum.GUARDIAN], | ||
| dstChainId: LzChainId.ethereum, | ||
| }, | ||
| { | ||
| target: ETHEREUM_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [ethereum.REDSTONE_ORACLE, "setDirectPrice(address,uint256)", ethereum.GUARDIAN], | ||
| dstChainId: LzChainId.ethereum, | ||
| }, |
There was a problem hiding this comment.
I wouldn't revoke these permissions
| }; | ||
| return makeProposal( | ||
| [ | ||
| // Revoke Permissions |
| }; | ||
| return makeProposal( | ||
| [ | ||
| // Revoke Permissions |
There was a problem hiding this comment.
The zero address was used to grant permissions on the IR models. So, I suppose we shouldn't use specific addresses to revoke these permissions, but the zero address
GitGuru7
reviewed
Sep 24, 2024
| { | ||
| target: ARBITRUM_ONE_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [ARBITRUM_ONE_PRIME, "setTokensDistributionSpeed(address[],uint256[])", arbitrumone.GUARDIAN], |
There was a problem hiding this comment.
Suggested change
| params: [ARBITRUM_ONE_PRIME, "setTokensDistributionSpeed(address[],uint256[])", arbitrumone.GUARDIAN], | |
| params: [ARBITRUM_ONE_PLP, "setTokensDistributionSpeed(address[],uint256[])", arbitrumone.GUARDIAN], |
GitGuru7
reviewed
Sep 24, 2024
| { | ||
| target: ARBITRUM_ONE_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [ARBITRUM_ONE_PRIME, "setMaxTokensDistributionSpeed(address[],uint256[])", arbitrumone.GUARDIAN], |
There was a problem hiding this comment.
Suggested change
| params: [ARBITRUM_ONE_PRIME, "setMaxTokensDistributionSpeed(address[],uint256[])", arbitrumone.GUARDIAN], | |
| params: [ARBITRUM_ONE_PLP, "setMaxTokensDistributionSpeed(address[],uint256[])", arbitrumone.GUARDIAN], |
GitGuru7
reviewed
Sep 24, 2024
| { | ||
| target: ARBITRUM_ONE_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [ARBITRUM_ONE_PRIME, "setMaxLoopsLimit(uint256)", arbitrumone.GUARDIAN], |
There was a problem hiding this comment.
Suggested change
| params: [ARBITRUM_ONE_PRIME, "setMaxLoopsLimit(uint256)", arbitrumone.GUARDIAN], | |
| params: [ARBITRUM_ONE_PLP, "setMaxLoopsLimit(uint256)", arbitrumone.GUARDIAN], |
GitGuru7
reviewed
Sep 24, 2024
| { | ||
| target: ARBITRUM_ONE_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [ARBITRUM_ONE_PLP, "updateAlpha(uint128,uint128)", arbitrumone.GUARDIAN], |
There was a problem hiding this comment.
Suggested change
| params: [ARBITRUM_ONE_PLP, "updateAlpha(uint128,uint128)", arbitrumone.GUARDIAN], | |
| params: [ARBITRUM_ONE_PRIME, "updateAlpha(uint128,uint128)", arbitrumone.GUARDIAN], |
GitGuru7
reviewed
Sep 24, 2024
| { | ||
| target: ARBITRUM_ONE_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [ARBITRUM_ONE_PLP, "updateMultipliers(address,uint256,uint256)", arbitrumone.GUARDIAN], |
There was a problem hiding this comment.
Suggested change
| params: [ARBITRUM_ONE_PLP, "updateMultipliers(address,uint256,uint256)", arbitrumone.GUARDIAN], | |
| params: [ARBITRUM_ONE_PRIME, "updateMultipliers(address,uint256,uint256)", arbitrumone.GUARDIAN], |
GitGuru7
reviewed
Sep 24, 2024
| { | ||
| target: ARBITRUM_ONE_ACM, | ||
| signature: "revokeCallPermission(address,string,address)", | ||
| params: [ARBITRUM_ONE_PLP, "setStakedAt(address[],uint256[])", arbitrumone.GUARDIAN], |
There was a problem hiding this comment.
Suggested change
| params: [ARBITRUM_ONE_PLP, "setStakedAt(address[],uint256[])", arbitrumone.GUARDIAN], | |
| params: [ARBITRUM_ONE_PRIME, "setStakedAt(address[],uint256[])", arbitrumone.GUARDIAN], |
There was a problem hiding this comment.
PLP should be replaced by prime and vice versa on many places
|
Closing this PR and will open new PR utilising ACMCommandsAggregator for revoking permissions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN